Skip to content

Support Node 22 and Windows CLI builds - #7

Merged
slate-rehm merged 1 commit into
masterfrom
t3code/fix-node22-windows-build
Aug 28, 2026
Merged

slate-rehm merged 1 commit into
masterfrom
t3code/fix-node22-windows-build

Conversation

@slate-rehm

@slate-rehm slate-rehm commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Support Node.js 22.19.0 and later for local development.
  • Use Node.js 22 types and test the minimum version in continuous integration.
  • Use portable double quotes for the command interface banner on Windows.
  • Keep deployment and release jobs on Node.js 24.

Checks

  • pnpm semark:check
  • pnpm check
  • pnpm build
  • pnpm exec wrangler deploy --dry-run --config apps/api/wrangler.jsonc
  • pnpm audit --prod --audit-level high
  • Command interface build and smoke test on Node.js 22.19.0

Release notes

  • Support Node.js 22.19.0 and later for local development.
  • Use Node.js 22 type definitions.
  • Test Node.js 22.19.0 in CI.
  • Update the minimum Node.js version in the documentation.
  • Use portable double quotes in the CLI banner for Windows builds.
  • Keep deployment and release jobs on Node.js 24.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a0099e02-526c-43d5-a85e-8f15b68e258f

📥 Commits

Reviewing files that changed from the base of the PR and between d30b210 and 0dca831.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • README.md
  • apps/cli/package.json
  • package.json

Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

The project now supports Node.js 22.19.0, updates Node.js type definitions, aligns CI and documentation, and changes CLI build banner quoting.

Changes

Node.js support alignment

Layer / File(s) Summary
Node.js version support
.github/workflows/ci.yml, README.md, package.json
The minimum Node.js version is 22.19.0. CI, documentation, package engines, and @types/node use the updated version.
CLI build command
apps/cli/package.json
The CLI build command uses double quotes around the esbuild shebang banner.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 0dca8

This PR broadens supported Node.js versions and adjusts Windows CLI quoting without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the two main changes: support for Node.js 22 and Windows CLI builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)


Comment @coderabbitai help to get the list of available commands.

@slate-rehm

Copy link
Copy Markdown
Contributor Author

#AI-Automation

  • Set the minimum supported version to Node.js 22.19.0.
  • Aligned the Node.js type definitions with Node.js 22.
  • Added Node.js 22.19.0 coverage to continuous integration.
  • Changed the command interface banner quotes for Windows compatibility.
  • Updated the development requirements in the README.
  • Ran all local checks with Node.js 22.19.0.
  • Confirmed that continuous integration passed.
  • Reviewed the CodeRabbit result. It had no actionable comments, so no review change was necessary.

@slate-rehm
slate-rehm enabled auto-merge (squash) August 28, 2026 16:59
@slate-rehm
slate-rehm disabled auto-merge August 28, 2026 16:59
@slate-rehm slate-rehm self-assigned this Aug 28, 2026
@slate-rehm
slate-rehm merged commit 921c147 into master Aug 28, 2026
2 checks passed
@slate-rehm
slate-rehm deleted the t3code/fix-node22-windows-build branch August 28, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant