Skip to content

fix: make checks portable across platforms - #5

Merged
slate-rehm merged 1 commit into
masterfrom
fix/windows-portability-pnpm
Aug 28, 2026
Merged

fix: make checks portable across platforms#5
slate-rehm merged 1 commit into
masterfrom
fix/windows-portability-pnpm

Conversation

@slate-rehm

@slate-rehm slate-rehm commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • migrate repository development and publishing from npm to pnpm 10.33.4
  • replace the Bash-only repository validator with a cross-platform Node validator
  • launch the Oxlint JavaScript entry point through the active Node runtime
  • add validator regression tests and Ubuntu/Windows CI on Node 20 and Node 24

Validation

  • pnpm run check on Node 24
  • pnpm run check on Node 20.20.2
  • actionlint on both GitHub Actions workflows
  • pnpm install --force --frozen-lockfile
  • pnpm pack --dry-run --json

Summary

  • Migrated development and package publishing from npm to pnpm 10.33.4.
  • Replaced the Bash repository validator with the cross-platform scripts/check.mjs validator.
  • Added regression tests for symlink checks and scaffold placeholder detection.
  • Updated Oxlint tests to use the active Node runtime.
  • Added Ubuntu and Windows checks for Node.js 20 and Node.js 24.
  • Updated package publishing to use frozen-lockfile installation and pnpm publish.
  • Validation passed with pnpm run check, actionlint, frozen-lockfile installation, and pnpm pack --dry-run --json.

@slate-rehm

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ed76136b-77ad-492d-8fbc-c5c70800f98a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f7df3892-eade-4bc4-abaf-c50af3e1898a

📥 Commits

Reviewing files that changed from the base of the PR and between e84c35a and c402592.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • .github/workflows/check.yml
  • .github/workflows/publish-package.yml
  • AGENTS.md
  • package.json
  • scripts/check.mjs
  • scripts/check.sh
  • tests/check-script.test.mjs
  • tests/oxlint-integration.test.mjs
💤 Files with no reviewable changes (1)
  • scripts/check.sh

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour.


📝 Walkthrough

Walkthrough

The change adds JavaScript-based repository validation, standardizes package commands on pnpm, updates CI and publishing workflows, and adjusts Oxlint integration tests for executable resolution.

Changes

Validation and pnpm workflow migration

Layer / File(s) Summary
Repository validation implementation and tests
scripts/check.mjs, tests/check-script.test.mjs
The new checks validate required symlinks, scaffold placeholders, skill metadata, and optional Python validation. Tests cover symlink and placeholder behavior.
pnpm scripts and local validation wiring
package.json, AGENTS.md
The package declares pnpm, adds repository check scripts, updates build and test commands, and documents pnpm run check.
CI and publishing workflow integration
.github/workflows/check.yml, .github/workflows/publish-package.yml, tests/oxlint-integration.test.mjs
CI checks run across Ubuntu, Windows, and Node.js versions. Publishing uses pnpm. Oxlint tests resolve and launch the installed executable through Node.js.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to c4025

This PR makes repository tooling and CI changes for cross-platform checks and pnpm adoption. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (4 skipped: 4… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: replacing the platform-specific validation script with portable checks and adding cross-platform CI coverage.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (4 skipped: 4 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@slate-rehm
slate-rehm merged commit 8722376 into master Aug 28, 2026
5 checks passed
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant