Add support for multiple md files - #9
Open
ivn-cote wants to merge 3 commits into
Open
Conversation
paprikka
requested changes
Apr 28, 2019
Owner
There was a problem hiding this comment.
Hey, added two minor changes, otherwise everything looks good. I've run this on a Win and *nix and everthing works smooth. If you publish an update on Mon, I should be able to merge the PR this week, otherwise I'll have some spare time on 01/05, so can merge and publish the NPM package then. Thanks a lot!
| exclude: /^\./ | ||
| }, | ||
| function(err, content, next) { | ||
| if (err) throw err |
Owner
There was a problem hiding this comment.
Can we swap this for reject(err)? Using a throw statement here might break promise chaining/catching.
Owner
There was a problem hiding this comment.
Also, can we cover this bit with a unit test case, i.e. mocking readFiles to throw an exception here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #8