Make CreateKey faster#85
Open
bgrainger wants to merge 1 commit into
Open
Conversation
Use BinaryPrimitives instead of BinaryWriter to write directly to the array instead of via a MemoryStream. Move allocation of the key outside the loop to avoid creating unnecessary temporary objects.
DocBrown101
reviewed
Jul 1, 2022
DocBrown101
left a comment
DocBrown101
left a comment
There was a problem hiding this comment.
Looks very good, would be nice if that could be released.
|
Yeah, this repo seems abandoned. If I learn how to put binaries up I could make temporary releases until the original author has time again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a "TODO" in the code:
BinaryPrimitivesinstead ofBinaryWriterto write directly to the array instead of via aMemoryStream.For a local Minecraft map, this change reduced the first phase from 3:33.6 to 3:21.7.