Refactor/update - #74
Merged
Merged
Conversation
Refactored ProcessesPage to replace service actions with process-specific actions (Start, Kill, Restart, View Properties) in both context menu and DropDownButton. The Ellipse icon now binds its Fill property to the data context. Improved process list layout and margins. Renamed event handlers to match process actions. Added InfoBar notification helpers and named the root Grid for dynamic InfoBar display. Minor margin tweaks in ServicesPage for consistency.
- Removed "View Properties" from context/dropdown menus - Added allProcesses backing collection for filtering - Implemented filter logic and UI update helpers - Refresh now reloads processes asynchronously - Stubbed out process start/kill/restart handlers - Refactored process loading and color assignment - Added ordering by state and name - Improved error handling for missing client
Changed the SelectorBar Margin property from "-10, -8" to "-10, -8, 0, -24" in ServerMainPage.xaml to refine its positioning and spacing within the layout.
Added ComboBox for process ordering (Default, Name, PID, Uptime, State) and refactored ordering logic accordingly. Improved toolbar UI with spacing and accent style. Added confirmation dialog before killing a process.
- Add ProgressRing to indicate loading state in UI - Enable NavigationCacheMode and track endpoint to avoid redundant reloads - Add cancellation support for initialization and data loading - Refactor to separate client resolution, initialization, and data loading - Improve error handling and show errors via InfoBar - Refresh button now triggers non-cancellable reload - Show/hide ProgressRing during load operations
Updated AgentClient to use Resources.V2. Added new resources.proto for V2 with expanded system resource and process management messages. Updated project file to generate gRPC client code for V2 while retaining V1 for compatibility.
- Switch gRPC resource usage from Resources.V1 to Resources.V2. - Change KillProcessRequest.pid from uint32 to int32 in proto. - Implement process kill operation with error handling and user feedback in ProcessesPage.xaml.cs. - Show process name in kill confirmation dialog. - Assign ProcessId directly from int Pid field.
Refactored process kill handling to update the affected process's visual state directly, avoiding unnecessary reloads. Introduced UpdateProcessVisualStateAsync to change process color and status based on actions. Added general exception handling to process loading with user feedback on errors.
Removed the "Start" menu item from the process context menu in ProcessesPage and deleted its unused event handler. Users can no longer attempt to start a process from the context menu.
Changed the icon for the "Processes" SelectorBarItem from "Favorite" to "Component" in ServerMainPage.xaml for improved clarity and consistency.
- Replace killProcess RPC with generic ProcessAction RPC (pid + sig) - Add Terminate, Kill, Reload, Pause, Resume, Call actions to process UI - Implement new handlers in ProcessesPage.xaml.cs for each action, mapping to Unix signals - Improve user feedback with dialogs and info bars - Change Processes selector icon to "ViewAll" - Improve error handling and code clarity throughout
Switched codebase references from Services.V2 to Services.V3. Added new services.proto (V3) with HandlerService for unit actions and queries. Updated resources.proto: added CPU metrics, renamed ProcessActionRequest field, improved formatting. Registered V3 proto in project for gRPC client generation. Enhances system unit management and resource reporting via gRPC.
Replaced 'Sig' with 'Signal' in all ProcessActionRequest usages to match the correct property name. Updated using directives in ServicesPage.xaml.cs to use Resources.V2 and Services.V3, removing older versions.
Replaced the Resources.V1 namespace with Resources.V2 in srvOverview.xaml.cs to reference the latest resource or service definitions. This ensures the code uses updated versions and maintains compatibility with newer APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.