fix: preserve hidden Slack links in agent prompts#729
Merged
Conversation
e334ec1 to
fefdfab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
continue.Links included in the Slack messagesection to the agent prompt so linked Slack threads are visible to the agent.Root Cause
Slack messages with manually hyperlinked words can arrive with plain adapter text such as
continuewhile the URL lives in Slack rich-text blocks or adapter link metadata. Slackbot was forwarding only the plain text when it was non-empty, so the agent had no way to know a linked thread existed.Validation
bun test test/session-api.test.tspnpm --filter slackbotv2 check:typesNote: the clean PR worktree does not have Node dependencies installed; validation was run in the main checkout against the same patch before creating the PR branch.