Repository navigation
Conversation
xenoliss
marked this pull request as ready for review
November 11, 2026 15:20
xenoliss
force-pushed
the
baptisteoueriagli/chain-6923-upstream-pr-reth-core-matches
branch
from
November 12, 2026 15:21
af75209 to
17ff2fe
Compare
`RecoveredBlock::find_indexed`, `IndexedTx::tx_hash` and `IndexedTx::meta` identified transactions by `Encodable2718::trie_hash`, the keccak256 of the EIP-2718 encoding. For transaction types whose hash is not the hash of their encoding, `find_indexed` misses the transaction and the returned metadata carries the wrong hash. Use the cached `TxHashRef::tx_hash` instead, keeping `trie_hash` for trie and proof commitments, as paradigmxyz/reth#24494 did in reth.
xenoliss
force-pushed
the
baptisteoueriagli/chain-6923-upstream-pr-reth-core-matches
branch
from
November 12, 2026 19:28
17ff2fe to
d85b3cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecoveredBlock::find_indexed,IndexedTx::tx_hashandIndexedTx::metaidentify a transaction byEncodable2718::trie_hash, the keccak256 of its EIP-2718 encoding. That is the transaction hash only when the two are equal. For a transaction type where they differ,find_indexed(tx_hash)returnsNone, so reth's in-memory lookups such aseth_getTransactionByHashfor a not-yet-persisted block miss the transaction, andmeta()carries the wrong hash.This uses
TxHashRef::tx_hashinstead and keepstrie_hashfor trie and proof commitments, applying the rule from paradigmxyz/reth#24494 toreth-primitives-traits.