Conversation
The Interval and Mine components used a zero-width-space character inside a Text element as a vertical spacer to align buttons with input fields. Both were marked with a TODO to remove the hack. Replace it with alignVertical="bottom" on the Inline wrapper, which aligns child elements to the bottom of the flex row via align-items: flex-end. The buttons now sit flush with the bottom of the input fields without a phantom element. Closes paradigmxyz#117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the invisible zero-width-space character ({
\u200e}) used as a vertical spacer in the Interval and Mine components of block-config.tsx with proper CSS alignment. Both occurrences were marked with a TODO: don't do this lol comment.The fix uses alignVertical="bottom" on the Inline wrapper, which maps to align-items: flex-end and aligns the child buttons to the bottom of the row, matching the input fields without a phantom element.
Verified: biome check, tsc --noEmit, and bun run build all pass.
Closes #117