Conversation
The Tokens component previously mapped over tokens and returned null for invisible entries, rendering nothing when the account had no visible tokens. This made an empty account indistinguishable from a broken or loading state. Add a loading spinner shown while tokens are fetching, a "No tokens found for this account" message when all tokens are filtered out, and preserve the existing token row rendering for visible tokens. Closes paradigmxyz#118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tokens component in account details previously mapped over tokens and returned null for invisible entries. When the account had no visible tokens the tab rendered column headers with a blank area underneath and no feedback. The code carried a TODO: Handle empty state. comment.
This change adds a loading spinner shown while tokens are being fetched, a "No tokens found for this account" message shown when the loaded token list has no visible entries, and keeps the existing rendering for visible tokens. The three states (loading, empty, populated) are now visually distinct.
Verified: biome check, tsc --noEmit, and bun run build all pass.
Closes #118