-
Notifications
You must be signed in to change notification settings - Fork 88
docs: update CHANGELOG #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updates the CHANGELOG and also adds releasing steps in the README to remember in the future! Signed-off-by: Hugues de Valon <hugues.de-valon@einride.tech>
Jakuje
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thank you!
wiktor-k
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it's better than nothing, even if I'm personally not a fan of these automatically generated changelogs 😅
|
|
||
| ## [cryptoki-0.11.0](https://github.com/parallaxsecond/rust-cryptoki/tree/cryptoki-0.11.0) (2025-12-19) | ||
|
|
||
| [Full Changelog](https://github.com/parallaxsecond/rust-cryptoki/compare/cryptoki-sys-0.5.0...cryptoki-0.11.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These links look weird and when followed github says that "there's nothing to compare as they are identical" (paraphrasing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I mised this. It should probably be like this?
cryptoki-sys-0.4.0...cryptoki-sys-0.5.0
or even
cryptoki-0.10.0...cryptoki-0.11.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And I missed that the "auto merge" was enabled 😅 well, no big deal, but if the thing was generated by the tool and requires manual fixes this sounds like a recipe for problems 😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the automatic generation tools is not smart enough to know what tags to use for the diff 😅 It's not really made for repos where there are two crates sharing two sets of tags. If we change it manually here then it will be overwritten next time.
I think the best for the future would be to write our changelogs manually but not sure it's worth the time...
Updates the CHANGELOG and also adds releasing steps in the README to remember in the future!