Skip to content

Conversation

@hug-dev
Copy link
Member

@hug-dev hug-dev commented Jan 7, 2026

Updates the CHANGELOG and also adds releasing steps in the README to remember in the future!

Updates the CHANGELOG and also adds releasing steps in the README to
remember in the future!

Signed-off-by: Hugues de Valon <hugues.de-valon@einride.tech>
@hug-dev hug-dev marked this pull request as ready for review January 7, 2026 13:26
@hug-dev hug-dev mentioned this pull request Jan 7, 2026
Copy link
Collaborator

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you!

@hug-dev hug-dev requested a review from wiktor-k January 7, 2026 14:44
@hug-dev hug-dev enabled auto-merge January 7, 2026 14:44
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's better than nothing, even if I'm personally not a fan of these automatically generated changelogs 😅


## [cryptoki-0.11.0](https://github.com/parallaxsecond/rust-cryptoki/tree/cryptoki-0.11.0) (2025-12-19)

[Full Changelog](https://github.com/parallaxsecond/rust-cryptoki/compare/cryptoki-sys-0.5.0...cryptoki-0.11.0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links look weird and when followed github says that "there's nothing to compare as they are identical" (paraphrasing).

Copy link
Collaborator

@Jakuje Jakuje Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I mised this. It should probably be like this?
cryptoki-sys-0.4.0...cryptoki-sys-0.5.0
or even
cryptoki-0.10.0...cryptoki-0.11.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I missed that the "auto merge" was enabled 😅 well, no big deal, but if the thing was generated by the tool and requires manual fixes this sounds like a recipe for problems 😱

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the automatic generation tools is not smart enough to know what tags to use for the diff 😅 It's not really made for repos where there are two crates sharing two sets of tags. If we change it manually here then it will be overwritten next time.

I think the best for the future would be to write our changelogs manually but not sure it's worth the time...

@hug-dev hug-dev merged commit 2fb2da8 into parallaxsecond:main Jan 8, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants