Repository navigation
AKS, Redis and custom role fetchers: an unread list gives null counts, not 0 - #367
Merged
Merged
Conversation
…be read A cluster, cache or role definition list that could not be read left every summary count at 0 or empty. Each count built from it is now null, as is each count built from a per-cache or per-cluster read that failed. The run still fails as before. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> # Conflicts: # CHANGELOG.md
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CHANGELOG.md: keep both Fixed entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bruceweygandt
approved these changes
Nov 16, 2026
bruceweygandt
left a comment
Contributor
There was a problem hiding this comment.
Approved. An unread cluster, cache or role list now nulls every summary field, and a failed per-cache or per-cluster read nulls the counts built from it. Text, versions and CHANGELOG match the code. I merged main (CHANGELOG conflict with #366: both entries kept); the full suite passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FDE-1200
Part of FDE-1190
Summary
When a fetcher can't read a list (a 403, throttling, a timeout), every total, count and percentage built from it is now null, never 0. Partial failure is still set as before (exit 1). Same rule and pattern as #335, #336 and #339.
azure_aks_cluster_configuration0.5.0: all summary counts, percentages and lists (kubernetes_versions,node_image_versions) are null when the cluster list could not be read. Before,total_clustersand every count read 0 and the lists were empty.azure_redis_cache_configuration0.3.0: all summary counts,caches_by_sku,caches_by_redis_versionandexceptionsare null when the cache list could not be read. Counts built from a per-cache read (access_policy_assignments,firewall_allows_all_ips_caches,audit_logging_enabled_caches,maintenance_window_caches,geo_replicated_caches) are null while any cache's read failed; before, that cache was left out of the count.azure_managed_redis_configuration0.3.0: all summary counts are null when the cluster list could not be read. The database counts,tls_only_clustersandtls_only_percentageare null while any cluster's database list could not be read.azure_rbac_custom_roles0.3.0: all summary counts (total_role_definitions,builtin_role_definitions,custom_role_definitionsand every count below) andcustom_roles_with_escalation_namesare null when the role definition list could not be read.A list that was read and is empty still gives 0 (or
[]). The plain-textinstructionsin eachfetcher.yamlnow say which counts are null and when. CHANGELOG entry under Unreleased > Fixed.Tests
tests/test_azure_unread_lists_null_counts.py(synthetic data only):main()run with its top-level list refused: every summary count is null (the exclusion fields are covered by existing tests) and the run exits 1.The new tests fail on
origin/main's fetcher code (10 of 11 fail; verified with a temporary revert commit) and pass with the fix. Also run:test_contracts.py,test_azure_aks_node_security.py,test_azure_resource_exclusions_{compute,databases,references}.py,test_azure_sdk_surface.py(1608 passed), including theassert_summary_documentedchecks.Validator check
No validator on
mainreads these fetchers. Onadded-validators, nine do:azure_rbac_custom_roles_no_all_actions_or_root_scope,azure_rbac_custom_roles_no_privilege_escalation,azure_redis_all_clusters_private_only,azure_redis_all_clusters_tls_only: each regex needs a digit in the summary field (andpartial_failurefalse, or a total of 1 or more), so a null value does not match, as 0 did not before. Verdict unchanged, checked with each regex in Node against null and 0 summaries.azure_redis_all_clusters_zone_redundant,azure_redis_client_protocol_present,azure_redis_geo_replication_field_present,azure_redis_no_plaintext_databases,azure_redis_redundancy_fields_present: read per-cluster or per-database fields underresults, not the summary. Unaffected.🤖 Generated with Claude Code