Repository navigation
validators: Azure Velero, flexible server backups, endpoint availability and AKS node OS - #382
Open
bruceweygandt wants to merge 2 commits into
Open
bruceweygandt wants to merge 2 commits into
bruceweygandt wants to merge 2 commits into
Conversation
…bility and AKS node OS validators
bruceweygandt
force-pushed
the
feat/azure-new-fetcher-validators
branch
from
November 17, 2026 20:48
5c4e5cc to
8dbd0be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 41 validators for the four new Azure fetcher PRs:
azure_velero_backups(#376),azure_flexible_server_backups(#377),azure_endpoint_availability(#378) and the newaks_cluster_configurationnode OS fields (#380). Per the new rule, validators go toall-validatorsonly; the fetcher PRs carry no validators. Written against the fetchers as revised after review.The three new sets are added to
common/collection_succeeded.yamlfor run health.Review feedback applied
No Current Failed Backups,No Current Incomplete Volume SnapshotsandNo Current Restore Errorsread the fetcher's new_unresolvedcounts. Resolved failures and deliberate failure tests stay in the totals, so a healthy result never requires deleting history.Every Schedule Succeeded Within the Daily Windowuses each listed schedule's own interval plus 10% (26 hours fordaily:24);No Schedule Exceeds the Recovery Point Objectiveusesrpo_hours.Not included, and why
Merge order
Merge after #376, #377, #378 and #380, so every field these validators read exists on the fetchers. The #377 rename means the database set is
EVD-AZURE-FLEXIBLE-SERVER-BACKUPS.Steps to validate
paramify validators check: 2,795 cases across 484 files, 0 failed, 0 vacuous passes. The new files add 240 cases: for each validator, compliant, non-compliant, empty population and ten-times scale where it compares counts,null, and the key renamed upstream; for each set, all compliant, one check failing, undecided values unset, and a failed collection.pytest tests/test_validators_registry.py tests/test_validator_api.py tests/test_validator_sync.py tests/test_validate_secrets.py: 421 passed.