Skip to content

validators: Azure Velero, flexible server backups, endpoint availability and AKS node OS - #382

Open
bruceweygandt wants to merge 2 commits into
all-validatorsfrom
feat/azure-new-fetcher-validators
Open

bruceweygandt wants to merge 2 commits into
all-validatorsfrom
feat/azure-new-fetcher-validators

Conversation

@bruceweygandt

@bruceweygandt bruceweygandt commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds 41 validators for the four new Azure fetcher PRs: azure_velero_backups (#376), azure_flexible_server_backups (#377), azure_endpoint_availability (#378) and the new aks_cluster_configuration node OS fields (#380). Per the new rule, validators go to all-validators only; the fetcher PRs carry no validators. Written against the fetchers as revised after review.

Evidence set Validators Integrity Configuration
EVD-AZURE-VELERO-BACKUPS 18 5 13
EVD-AZURE-FLEXIBLE-SERVER-BACKUPS 9 3 6
EVD-AZURE-ENDPOINT-AVAILABILITY 12 2 10
EVD-AZURE-AKS-CONFIG 2 1 1

The three new sets are added to common/collection_succeeded.yaml for run health.

Review feedback applied

  • Undecided values read as not set and incomplete, never as a pass. Each adopted value (expected schedules, RPO, restore-test interval, database retention, restore lookback, availability target) gets its own "... Is Configured" validator that names the cause. The check that judges against that value also fails while it is unset, so an evidence set with an undecided value is never green, and the "Is Configured" validator shows the reason is a missing setting rather than a broken backup, restore or endpoint.
  • Current failures, not history. No Current Failed Backups, No Current Incomplete Volume Snapshots and No Current Restore Errors read the fetcher's new _unresolved counts. Resolved failures and deliberate failure tests stay in the totals, so a healthy result never requires deleting history.
  • Daily check apart from the RPO. Every Schedule Succeeded Within the Daily Window uses each listed schedule's own interval plus 10% (26 hours for daily:24); No Schedule Exceeds the Recovery Point Objective uses rpo_hours.
  • Off-site check says what is replicated. The Velero geo-replication validator covers what Velero writes to the storage account (resource backups and metadata, and file-system backup data if used) and says it does not cover volume snapshots taken by the Azure disk snapshotter.
  • Restore checks don't overclaim. Restore statements say a restore without errors does not show the recovered application works and does not prove the recovery time objective, which needs a timed recovery walkthrough.
  • Endpoint checks are inputs. Every endpoint availability statement says the checks are inputs to availability reporting, not a replacement for it. Two "Was Judged" validators make sure no test or load balancer silently escapes the target check.
  • Node OS patching is its own check. The AKS validator reads the node OS upgrade channel only, counts Unmanaged apart (the node OS may still install its own updates), says an enabled channel does not show updates were applied, and leaves Kubernetes version upgrades to a separate check.

Not included, and why

  • Customer-managed key checks (Velero storage, PostgreSQL and MySQL): on hold until the intended key setup is confirmed. Platform-managed keys still encrypt, so these must not report an encryption failure yet.
  • Autoscaling: waiting on how to identify the node pools intended to scale; checking every pool is not the requirement.
  • Volume snapshot off-site copy: needs a fetcher field for disk snapshot replication, pending confirmation of whether a cross-region copy is configured.

Merge order

Merge after #376, #377, #378 and #380, so every field these validators read exists on the fetchers. The #377 rename means the database set is EVD-AZURE-FLEXIBLE-SERVER-BACKUPS.

Steps to validate

  • paramify validators check: 2,795 cases across 484 files, 0 failed, 0 vacuous passes. The new files add 240 cases: for each validator, compliant, non-compliant, empty population and ten-times scale where it compares counts, null, and the key renamed upstream; for each set, all compliant, one check failing, undecided values unset, and a failed collection.
  • pytest tests/test_validators_registry.py tests/test_validator_api.py tests/test_validator_sync.py tests/test_validate_secrets.py: 421 passed.
  • Every regex is 150 characters or fewer (longest 149). Case artifacts are synthetic, built from the revised fetchers' own test output with no tenant data.

@bruceweygandt
bruceweygandt force-pushed the feat/azure-new-fetcher-validators branch from 5c4e5cc to 8dbd0be Compare November 17, 2026 20:48
@bruceweygandt bruceweygandt changed the title validators: Azure Velero, database backups, endpoint availability and AKS node OS validators: Azure Velero, flexible server backups, endpoint availability and AKS node OS Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant