Repository navigation
Add paramify upload --no-waf-check - #386
Merged
Merged
Conversation
…would drop The delivery plan drops any file holding '../', '/etc/passwd', '/bin/sh', '/bin/bash' or '<script' before it is sent, because those strings were confirmed blocked on one host's WAF. Some hosts exempt the upload routes, so CVE text in an Inspector ECR findings file was dropped locally even though the WAF would have accepted it, and no request ever reached the server. --no-waf-check turns the pre-check off for one run (upload and --plan). The file is sent; if the WAF does refuse it (a 403 with no requestId), the existing per-file handling still drops only that file and sends the rest. The plan notes that the check is off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
paramify upload --no-waf-check(and--plan --no-waf-check) turns the pre-check off for one run. Every file is sent.requestId), the existing handling inClient.classifystill drops only that file and sends the rest. Nothing else changes.cli_guide.mdflag table, theuploader_guide.mdtroubleshooting row (it now points to the flag), and the CHANGELOG.Tests
test_waf_check_off_sends_a_matching_file: the provider keeps a matching file when the check is off.test_no_waf_check_sends_the_file_and_notes_it: end to end against the fake API, both files are uploaded, none are dropped, and the plan has the note.test_no_waf_check_reaches_the_offline_plan: the same throughapi.plan_upload.upload_runandplan_upload.The touched suites pass (239), and
ruff check framework/andmypy framework/are clean.Follow-up to consider
The pre-check may now be wrong by default on gov. One option is to make it opt-in, or to keep the scan only as a "likely cause" hint after a real WAF 403.
🤖 Generated with Claude Code