Skip to content

Add paramify upload --no-waf-check - #386

Merged
21tmccauley merged 1 commit into
mainfrom
fix/upload-waf-precheck-flag
Nov 17, 2026
Merged

21tmccauley merged 1 commit into
mainfrom
fix/upload-waf-precheck-flag

Conversation

@21tmccauley

@21tmccauley 21tmccauley commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

What

  • paramify upload --no-waf-check (and --plan --no-waf-check) turns the pre-check off for one run. Every file is sent.
  • If the WAF does refuse a file (a 403 with no requestId), the existing handling in Client.classify still drops only that file and sends the rest. Nothing else changes.
  • With the flag on, the plan adds a note that the check is off.
  • Default behaviour is unchanged.
  • Docs: cli_guide.md flag table, the uploader_guide.md troubleshooting row (it now points to the flag), and the CHANGELOG.

Tests

  • test_waf_check_off_sends_a_matching_file: the provider keeps a matching file when the check is off.
  • test_no_waf_check_sends_the_file_and_notes_it: end to end against the fake API, both files are uploaded, none are dropped, and the plan has the note.
  • test_no_waf_check_reaches_the_offline_plan: the same through api.plan_upload.
  • CLI: the flag reaches upload_run and plan_upload.

The touched suites pass (239), and ruff check framework/ and mypy framework/ are clean.

Follow-up to consider

The pre-check may now be wrong by default on gov. One option is to make it opt-in, or to keep the scan only as a "likely cause" hint after a real WAF 403.

🤖 Generated with Claude Code

…would drop

The delivery plan drops any file holding '../', '/etc/passwd', '/bin/sh',
'/bin/bash' or '<script' before it is sent, because those strings were
confirmed blocked on one host's WAF. Some hosts exempt the upload routes, so
CVE text in an Inspector ECR findings file was dropped locally even though
the WAF would have accepted it, and no request ever reached the server.

--no-waf-check turns the pre-check off for one run (upload and --plan). The
file is sent; if the WAF does refuse it (a 403 with no requestId), the
existing per-file handling still drops only that file and sends the rest.
The plan notes that the check is off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@21tmccauley
21tmccauley merged commit b059907 into main Nov 17, 2026
19 checks passed
@21tmccauley
21tmccauley deleted the fix/upload-waf-precheck-flag branch November 17, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant