Support PHPUnit its --only-repeat-failed option#218
Closed
PieterDC wants to merge 18 commits intoparatestphp:masterfrom
Closed
Support PHPUnit its --only-repeat-failed option#218PieterDC wants to merge 18 commits intoparatestphp:masterfrom
PieterDC wants to merge 18 commits intoparatestphp:masterfrom
Conversation
# Conflicts: # src/ParaTest/Console/Commands/ParaTestCommand.php # src/ParaTest/Runners/PHPUnit/BaseRunner.php # src/ParaTest/Runners/PHPUnit/Options.php
…the PHPUnit library. Tests run once by default.
# Conflicts: # test/unit/ParaTest/Console/Commands/ParaTestCommandTest.php
…the PHPUnit library. Tests run once by default. - part 2.
…d EmptyRunnerStub. Not only in Runner.
# Conflicts: # test/unit/ParaTest/Console/Commands/ParaTestCommandTest.php
Contributor
|
Wow what happened to your history? That's 8 lines per commit. I guess that's what happens when you really apply commit early, commit often ;) For the phpunit PR: I think you need to direct every PR to the master. It then get's merged to all maintained releases (if they whish so). |
Contributor
Contributor
|
Without the --only-repeat-failed option in phpunit, there is nothing to support in paratest |
Author
|
I haven't made progress on sebastianbergmann/phpunit#1965 Also not in a separate issue. Also not on my local machine. All code I have/had concerning that issue is pushed. I agree that
So the PHPUnit feature request ideally has to be finished first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPUnit doesn't have an option to only repeat failed tests yet. But we provided a pull request for it: sebastianbergmann/phpunit#1965
And we coded ParaTest support for --only-repeat-failed, building upon what has been done for the --repeat option: #217