Skip to content

[common] feature add - ClusterIP for service manifest #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArshamTeymouri merged 2 commits into from
Oct 8, 2025
Merged

[common] feature add - ClusterIP for service manifest #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0815dd8
[common] feature add - ClusterIP for service manifest
ArshamTeymouri Oct 8, 2025
19c90fe
add helm docs
ArshamTeymouri Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/common/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: common
description: A generic helm chart for Kubernetes
type: application
version: 0.11.1
version: 0.12.0
maintainers:
- name: Parity
url: https://github.com/paritytech/helm-charts
3 changes: 2 additions & 1 deletion charts/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ This is intended behaviour. Make sure to run `git add -A` once again to stage ch
| replicaCount | int | `1` | Number of replicas for the pod |
| resources | object | `{}` | Resource limits & requests |
| secrets | object | `{}` | Creates a secret resource The value must be base64 encoded |
| service | object | `{"annotations":{},"ports":[],"sessionAffinity":"","type":"ClusterIP"}` | Creates a service resource |
| service | object | `{"annotations":{},"clusterIP":"","ports":[],"sessionAffinity":"","type":"ClusterIP"}` | Creates a service resource |
| service.annotations | object | `{}` | Annotations to add to the Service resource |
| service.clusterIP | string | `""` | Headless service |
| service.ports | list | `[]` | Ports to expose on the service |
| service.sessionAffinity | string | `""` | Session Affinitiy type |
| service.type | string | `"ClusterIP"` | Service type |
Expand Down
3 changes: 3 additions & 0 deletions charts/common/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ metadata:
{{- end }}
spec:
type: {{ .Values.service.type }}
{{- if and .Values.service.clusterIP (eq .Values.service.type "ClusterIP") }}
clusterIP: {{ .Values.service.clusterIP }}
{{- end }}
{{- if .Values.service.sessionAffinity }}
sessionAffinity: {{ .Values.service.sessionAffinity }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/common/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ service:
annotations: {}
# -- Service type
type: ClusterIP
# -- Headless service
clusterIP: ""
# -- Session Affinitiy type
sessionAffinity: ""
# -- Ports to expose on the service
Expand Down