test: Reorganize the integration tests for better navigability and maintainability.#271
Open
TarikGul wants to merge 11 commits into
Open
test: Reorganize the integration tests for better navigability and maintainability.#271TarikGul wants to merge 11 commits into
TarikGul wants to merge 11 commits into
Conversation
…g-integration-test-reorg
filvecchiato
previously approved these changes
Mar 9, 2026
eugypalu
requested changes
Mar 17, 2026
| println!("ok: Coretime regions sorting test passed"); | ||
| Ok(()) | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
I think these two lines are the last lines of the test_coretime_regions_sorting function in regions.rs
| @@ -0,0 +1,486 @@ | |||
| // Copyright (C) 2026 Parity Technologies (UK) Ltd. | |||
Collaborator
There was a problem hiding this comment.
[[test]]
name = "coretime"
path = "tests/coretime/mod.rs"
I think we need to add this [[test]] entry to Cargo.toml, otherwise Cargo won't discover the coretime tests
Imod7
reviewed
Mar 17, 2026
Contributor
Imod7
left a comment
Imod7
left a comment
There was a problem hiding this comment.
Under tests/fixtures we have 2 folders
asset-hub-kusamaasset-hub-polkadot
but also another 2 folders
kusama-asset-hubpolkadot-asset-hub
Maybe we could keep only one pair and put all files there ?
Examples of fixtures that exist but are not used
polkadot/blocks/10000001.jsonpolkadot/staking/progress_12000.jsonvalidators_11350267.jsonstorage_5000000_v13.jsonstorage_10000000_v14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganizes the integration tests for better navigability and maintainability. This PR addresses the growing complexity of the test suite by:
closes: #88