feat: convert into a library#34
Conversation
|
@ggwpez pingging for visibility. |
ggwpez
left a comment
There was a problem hiding this comment.
Looks good, thanks. Is it a library crate now? I dont see a [lib] entry, i think that is needed.
|
@ggwpez it is, yes. Simply create a new project with [dependencies]
psvm = { git = "https://github.com/moliholy/psvm", branch = "feat/convert-to-library" }Then in the
AFAIK you don’t need a |
There was a problem hiding this comment.
Looks good to me! Thanks for the contribution. Will fix compilation warning and failing test in another PR, it is also failing in main branch, might be cause target branch (of the test) on Polkadot SDK changed. Will publish to crates.io after this.
|
@patriciobcs thanks a lot! 🙏 |
|
@patriciobcs any progress on this? We're waiting for this to become a library to be able to actively use it as part of pop-cli's features. |
|
Merged! Will publish new crate release after merging tests fix PR #35 |
|
Awesome, thanks! 🙏 |
|
@moliholy new version is ready on crates.io in case you need it https://crates.io/crates/psvm |
|
@patriciobcs many thanks! I'll make good use of it ✨ |

This PR essentially transforms the current repository into a mixture of binary/library. The main idea is that other projects can import
psvmas a library and utilize its public API.Tests are failing, but also in the main branch. It should be automatically fixed once they are fixed in the main branch.EDIT: On a second thought, perhaps it's just in my local machine. Let's see what the CI says.