This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Draft
Conversation
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Member
The index should be required and not be optional. |
Contributor
Author
@bkchr By default, the index is derived from the order in which the pallets appear in the struct. If this attribute is specified, this default index is overridden. This is consistent with the current behaviour of |
Member
|
The indexes should be obligatory. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/polkadot-sdk#232
This PR introduces outer-macro approach for
construct_runtimeas discussed in the linked issue. It looks like the following:Features
#[frame::runtime]attached to a struct defines the main runtime#[frame::pallets]attached to a struct defines the pallets in the runtime#[frame::derive]attached to this struct defines the types generated byconstruct_runtime#[frame::pallet_index]can be optionally attached to a pallet to override its index#[frame::disable_call]can be optionally attached to a pallet to disable its callsTemplateModule: pallet_template<Instance>Todo
#[frame::disable_unsigned]to disable unsigned callsExtension