BUILD: export well known build parameters to gambit compiler - #367
Merged
mgorges merged 2 commits intoOct 14, 2020
Merged
Conversation
Contributor
|
Before we set these all in stone, as APP_ABI is only used in ANDROID, so maybe we should rename it to ANDROID_ABI or SYS_ANDROID_ABI to be consistent? Also what do we need SYS_ROOT for? |
Contributor
Author
|
Am Tue, 13 Oct 2020 19:59:31 -0700
schrieb Matthias Görges <notifications@github.com>:
Before we set these all in stone, as APP_ABI is only used in ANDROID,
so maybe we should rename it to ANDROID_ABI or SYS_ANDROID_ABI to be
consistent?
Agreed. Could be (for now) even being done locally at the spot.
Also what do we need SYS_ROOT for?
There an idea floating in my head, which would make this and a
to-be-cleaned-up similar small change here the only change required to:
a) get the jscheme support working (I know you are short on time, but
if you had a quick look at it, or remember your last assessment), this
module could be:
- all ever required in terms of JNI (maybe with the exception of very time-sensitive things)
- enable switching between LN's glgui and using webview and other
native Java stuff from just a few lines of Scheme
- switch layouts in the startup, thus possibly replacing special
cases like hybrid-app handling
- (update/added) put an end to android api version specific substitution tricks
b) I need to compile another `.so` for use with Android.
c) I need to find all the input components from within gambit. It
might be nowhere else needed. But for me it would be an empowering
feature. Likely others would like this too, once there's an example
use case.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the smallest change and most generic way I could come up with to tell the Scheme compiler more about the target environment.
Note that the
exported list might need to grow or being cut down. Right now it's just a suggestion. It will also require some care, as it is now "more-or-less-documented" once those build parameters where exported.SYS_ANDROIDAPIlooks right now like the minimum to make with #256 available on both older and newer versions.