fix(chat): include conversation history in Gemini prompt#658
Open
Tejas-h-blitz wants to merge 1 commit into
Open
fix(chat): include conversation history in Gemini prompt#658Tejas-h-blitz wants to merge 1 commit into
Tejas-h-blitz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
Conversation history sent by the client was never included in the prompt
sent to Gemini. The prompt construction used an
if/else ifchain whereSAFETY_INSTRUCTION(a module-level constant) is always truthy, so thehistoryBlockbranch never executed. Every message was treated as thefirst message in a new conversation.
Closes #645
📝 What does this PR do?
Replaces the broken
if/else ifchain with a single prompt builder thatalways includes both
SAFETY_INSTRUCTIONandhistoryBlock(whenpresent):
Also removed the redundant
typeof chatSchema !== 'undefined'guardsince
chatSchemais always defined in this file.🧪 How was this tested?
context
✅ Checklist