Zod validation resolved#667
Open
Tejas-h-blitz wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 What does this PR do?
Adds Zod validation for
GET /api/productsquery parameters.Previously, query params were parsed manually with no validation —
pagecouldbe negative,
limithad no upper bound, andsortaccepted arbitrary strings.This PR adds an inline Zod validation middleware that sanitizes and coerces all
query params before they reach the handler.
Changes:
productQuerySchematoserver/validation/requestSchemas.jssafeParsevalidation middleware toGET /api/productsinserver/routes/products.js400with field-level error details🔗 Related Issue
Closes #637
🧪 How was this tested?
Tested manually via browser and curl:
GET /api/products→ 200, defaults applied (page=1, limit=24, sort=productId_asc)GET /api/products?page=0→ 400, "page must be at least 1"GET /api/products?limit=200→ 400, "limit cannot exceed 100"GET /api/products?sort=random→ 400, invalid enum valueGET /api/products?page=2&limit=10&sort=price_desc→ 200, correct results📸 Screenshots (if UI changes)
N/A — backend only change, no UI affected.
✅ Checklist