Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .claude/memory/iterations.md
Original file line number Diff line number Diff line change
Expand Up @@ -452,3 +452,19 @@ Public:
- lib/utils.ts

**Issues found**: None. No fixes were required.

---

## 2026-03-20 — fix/brand-brief-route
**Type**: Bug fix
**Branch**: fix/brand-brief-route

**Root cause**: URL routing conflict between `app/(agency)/briefs/[id]/page.tsx` and `app/(brand)/briefs/new/page.tsx`. Both resolved to `/briefs/new`. Next.js served the agency dynamic route (`[id]="new"`), which immediately called `notFound()` because no brief with id="new" exists. The brand manager Submit Brief form was never rendered.

**Fix**:
- Moved `app/(brand)/briefs/new/page.tsx` → `app/(brand)/brand/briefs/new/page.tsx` (new URL: `/brand/briefs/new`)
- Updated `components/layout/Sidebar.tsx`: brand_manager Submit Brief href `/briefs/new` → `/brand/briefs/new`
- Updated `components/layout/RoleSwitcher.tsx`: brand_manager home route `/briefs/new` → `/brand/briefs/new`
- Removed now-empty `app/(brand)/briefs/` directories

**Result**: `/brand/briefs/new` serves the SubmitBriefForm correctly under the brand layout; no conflict with agency `/briefs/*` routes.
8 changes: 8 additions & 0 deletions .claude/memory/requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,3 +121,11 @@ Dragging cards to PENDING_APPROVAL or LIVE columns shows an error toast. Users m
### Partnership Request dialog — no role check in Phase 1
In Phase 1, the "Send Partnership Request" button is always visible on /creators/[handle].
Phase 3: restrict to agency role only.

---

## [DONE] Phase 1: /brand/briefs/new routing conflict
**Type**: Bug fix
**Priority**: P1 (blocker)
**What**: Brand manager "Submit Brief" page at `/briefs/new` was silently routed to the agency `briefs/[id]` dynamic route (id="new"), returning 404. Fixed by moving the brand route to `/brand/briefs/new` which has no overlap with any agency route.
**Status**: [DONE] — fix/brand-brief-route (2026-03-20)
File renamed without changes.
2 changes: 1 addition & 1 deletion components/layout/RoleSwitcher.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
const ROLE_HOME_ROUTES: Record<Role, string> = {
agency: '/dashboard',
creator: '/creator/deals',
brand_manager: '/briefs/new',
brand_manager: '/brand/briefs/new',
}

export function RoleSwitcher() {
Expand Down
2 changes: 1 addition & 1 deletion components/layout/Sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const NAV_ITEMS: Record<Role, NavItem[]> = {
{ label: 'Profile', href: '/creator/profile', icon: User },
],
brand_manager: [
{ label: 'Submit Brief', href: '/briefs/new', icon: PenLine },
{ label: 'Submit Brief', href: '/brand/briefs/new', icon: PenLine },
{ label: 'My Briefs', href: '/brand/briefs', icon: Inbox },
],
}
Expand Down
Loading