Skip to content

Besluitenzaal (bord-kamer C): vijf velden uit Claude's besluit 1 in de UI - #3

Merged
parvenuprompting merged 2 commits into
mainfrom
genius/bord-kamer-c
Sep 11, 2026
Merged

parvenuprompting merged 2 commits into
mainfrom
genius/bord-kamer-c

Conversation

@parvenuprompting

Copy link
Copy Markdown
Owner

Wat

Bord-kamer C = besluitenzaal in Grow Kit-stijl, op dezelfde besluiten-data-laag als optie A+B.

  • Kern (9f9d972): 'wacht op de Baas' rendert uit register-index + voorstellen-wachtrij; max-3-opties-wet afgedwongen.
  • Vijf velden uit BSL-040 / Claude's besluit 1 in de UI (0feec9d): keuze (max 3 opties), aanbeveling, vervaldatum, verstek, omkeerbaar. Verlopen voorstel rendert VERVALLEN + verstek-uitkomst.

Motorbewijs (geen zelfrapportage)

  • 21/21 unittest groen (unittest discover tests -p test_besluitenzaal*.py).
  • Echte render-ronde: alle vijf velden + VERVALLEN + verstek-uitkomst aanwezig in output (/tmp/besluitenzaal_bewijs.html).
  • TestLock kamerC-besluitenzaal-20260910: lock_check = SCHOON (96 testbestanden ongewijzigd), daarna release.

Merge

Pas na ratificatie door de Baas of KairOS.

KairOS and others added 2 commits September 9, 2026 14:52
…as' rendert uit register-index + voorstellen-wachtrij; max-3-opties wet afgedwongen; data blijft privé bij aanroeper
… max 3 + aanbeveling (bestaand), vervaldatum, verstek, omkeerbaar (nieuw); verlopen voorstel rendert VERVALLEN + verstek-uitkomst; 21 tests groen; motorbewijs via echte render (/tmp/besluitenzaal_bewijs.html)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0feec9d970

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

if not verval:
return False
try:
return _naar_iso(verval) < _naar_iso(vandaag)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate calendar dates before triggering default outcome

When a proposal contains a syntactically DD-MM-JJJJ but impossible date such as 31-02-2026, _naar_iso still returns a sortable string and this comparison reports it expired; render then adds VERVALLEN and states that the default outcome takes effect. Parse with a real calendar-date validator (and reject or leave invalid dates non-expired) before comparing so malformed proposal metadata cannot falsely display a default action.

Useful? React with 👍 / 👎.

Comment on lines +166 to +170
if v.get("omkeerbaar"):
hoe = _html.escape(v.get("omkeerbaar_hoe", ""))
velden.append(f'<span class="veld"><label>Omkeerbaar</label> ja' + (f" — {hoe}" if hoe else "") + "</span>")
elif v.get("vervaldatum") or v.get("verstek"):
velden.append('<span class="veld"><label>Omkeerbaar</label> nee</span>')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Render explicit non-reversible values

For a valid proposal containing only Omkeerbaar: nee, the parser represents that explicit declaration as False, just like an absent field. Neither branch then emits an Omkeerbaar label because the elif also requires a deadline or default outcome, so the UI silently hides the declared irreversibility. Preserve whether the field was supplied and render nee whenever it was explicitly provided.

Useful? React with 👍 / 👎.

def test_render_toont_drie_nieuwe_velden(self):
v = bz.parseer_voorstel(VOORSTEL_VOLLEDIG, "test.md")
uit = bz.render("", [v], [])
self._vijf_velden_in_html(uit)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Assert the field-rendering predicate

This test discards the boolean returned by _vijf_velden_in_html, so it succeeds even if rendering no longer includes any of the three new labels. Assert that result (for example, with self.assertTrue(...)) so the committed UI requirement is actually protected from regression.

Useful? React with 👍 / 👎.

@parvenuprompting
parvenuprompting merged commit 9e721f6 into main Sep 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant