solidity-auditor: Make it discover prior audits and calibrate severity#27
Open
0xumarkhatab wants to merge 1 commit into
Open
solidity-auditor: Make it discover prior audits and calibrate severity#270xumarkhatab wants to merge 1 commit into
0xumarkhatab wants to merge 1 commit into
Conversation
Turn 1 finds existing audit PDFs/MDs and extracts findings into prior-audits.md. Turn 4 cross-references each finding: REJECT if Fixed and present on main/master/dev (else tag as regression); downgrade one level if Acknowledged/Mitigated/Open; demote to LEAD if covered by a documented trust assumption. No-op if no audits or no pdftotext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
solidity-auditoraware of prior audit reports so it doesn'tre-elevate already-adjudicated issues at fresh-finding severity.
Changes
audits/,reports/,findings/,security/; extract title + severity + status into{bundle_dir}/prior-audits.md. Falls back ifpdftotextis missing.prior-audits.md:Fixed → REJECT (or
[regression-of:...]if not on current branch);Acknowledged/Mitigated/Open → downgrade one level +
[also-flagged-by:...];trust-assumption → demote to LEAD/NOTE.
Why
Prior auditor adjudication is strong Bayesian evidence of bounded
severity; re-scoring it as novel is a known false-positive pattern.
Conversely, a stale "Fixed" label that no longer holds is itself a
finding worth flagging.
Compatibility
No-op when audits or pdftotext are absent. No agent-bundle changes.