Conversation
a-corni
reviewed
Sep 11, 2026
a-corni
left a comment
a-corni
left a comment
Member
There was a problem hiding this comment.
Hey @danielgaskins!
Thanks for tackling this issue! It's looking good, I have only few nits before approving :)
a-corni
approved these changes
Sep 14, 2026
a-corni
left a comment
a-corni
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for your contribution @danielgaskins !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RegisterLayout.from_abstract_repr()currently ignores the class it is called on, which allows a specialized layout class to return an incompatible layout type.This change makes it a classmethod and passes the requested class to the standalone layout deserializer. Specialized classes now reject incompatible serialized layouts with a clear error. Calling the base class or standalone deserializer without a requested type keeps the existing automatic subtype detection.
Tests cover matching special layouts, generic layouts, base-class compatibility, explicit
None, and mismatches through both public APIs.Closes #1099
Tests: