[CI] PR workflows + pin actions - #293
Conversation
|
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: |
There was a problem hiding this comment.
Hmm, once a new commit is pushed test/lint/type check can just be cancelled as only the latest one matters no?
There was a problem hiding this comment.
As it is in this PR, in a PR I agree with you, when the commit sits in main or in a tag, I would leave it.
Reason behind would be if the test/lint/typecheck takes a bit longer, and we merge multiple PRs in a row, it can help pinpoint which commit broke the jobs.
We're nowhere near that kind of traffic in this repo, so I'm open to always have cancel-in-progress: true instead of cancel-in-progress: PR-only, WDYT?
There was a problem hiding this comment.
can help pinpoint which commit broke the jobs
ok valid point even though I'm not sure it can happen as those jobs must pass before the PR lands in main, anyway keep it as is that's not an issue :)
@Fenkiou Apologies, did not know you were reviewing! Let me address your comments, and I can open a follow-up PR with whatever we agree to fix |
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: |
There was a problem hiding this comment.
As it is in this PR, in a PR I agree with you, when the commit sits in main or in a tag, I would leave it.
Reason behind would be if the test/lint/typecheck takes a bit longer, and we merge multiple PRs in a row, it can help pinpoint which commit broke the jobs.
We're nowhere near that kind of traffic in this repo, so I'm open to always have cancel-in-progress: true instead of cancel-in-progress: PR-only, WDYT?
| doc-publish- | ||
| - run: pip install .[docs] | ||
| working-directory: pasqal-cloud | ||
| - run: mkdocs gh-deploy --force |
There was a problem hiding this comment.
Note: This is actually the only place that under the hood uses git, so that's the only place where we need the persist-credentials: true (the default value).
| push: | ||
| branches: | ||
| - main | ||
| - dev |
There was a problem hiding this comment.
dev branch isn't used anymore ;)
|
|
||
| concurrency: | ||
| group: tests-${{ github.event.pull_request.number || github.ref }} | ||
| # Superseded pull request runs are pointless; runs on main/dev are not. |
3 participants
Description
Remaining Tasks
Related PRs in other projects (PASQAL developers only)
Additional merge criteria
Breaking changes
Checklist
Versioning (PASQAL developers only)
VERSION.txtfollowing the changes in your PR and by using semantic versioning.Documentation
Tests
Internal tests pipeline (PASQAL developers only)
If your PR hasn't changed any functionality, it still needs to be validated against internal tests.
After updating the version (PASQAL developers only)