Skip to content

Add DataGraph.rectangular() and redefine DataGraph.square() as a convenience wrapper #443

Description

@alessandro-santini

The current DataGraph.square() implementation should be generalized and renamed to DataGraph.rectangular().

DataGraph.square() should remain available as the square-specific convenience method, implemented by calling DataGraph.rectangular() with equal side lengths. This should follow the same pattern used in [register.py](https://github.com/pasqal-io/qoolqit/blob/main/qoolqit/register.py).

Proposed changes

  • Rename/generalize the current DataGraph.square() implementation as DataGraph.rectangular().
  • Reimplement DataGraph.square() by calling DataGraph.rectangular() with the same value for both dimensions.
  • Update the relevant tests and documentation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions