Fix int-truncation bug in Waveform array sampling - #440
Merged
Merged
Conversation
|
v-vitale
approved these changes
Aug 11, 2026
v-vitale
left a comment
v-vitale
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
np.vectorizeinWaveform.__call__inferred its output dtype from the first sample, silently truncating later float samples to int when that first value happened to be an int.floatand casts values tofloatat the points where they could leak asint(_single_call,duration, and the constructors ofConstantWaveform,RampWaveform,BlackmanWaveform).Test plan
test_base_waveforms.pyandtest_derived_waveforms.pycovering the int-leak and the array/list sampling mismatch from the issue repro.