Skip to content

Scope graphs submodules - #442

Merged
sgrava merged 3 commits into
mainfrom
sg/441-scope-graphs-submodules
Aug 12, 2026
Merged

sgrava merged 3 commits into
mainfrom
sg/441-scope-graphs-submodules

Conversation

@sgrava

@sgrava sgrava commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Add clear scope to graph submodules and update class docstring accordingly.

Summary

  • Move node_weights/edge_weights (get+set) and from_matrix/to_matrix from DataGraph to BaseGraph, since they only need dependencies BaseGraph already has (networkx/numpy).
  • Keep DataGraph scoped to the named topology zoo (line, circle, triangular, hexagonal, heavy_hexagonal, square, random_er, random_ud) and PyTorch Geometric interchange (from_pyg/to_pyg), which pulls in an optional heavy dependency.
  • Rewrite both class/module docstrings (Google style) to reflect the new scope, since DataGraph is the only publicly-exposed type.
  • Relocate the corresponding from_matrix/to_matrix tests to test_base_graph.py.

Fixes #441

@sgrava sgrava linked an issue Aug 12, 2026 that may be closed by this pull request
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-12 12:48 UTC

@sgrava sgrava mentioned this pull request Aug 12, 2026
6 tasks
@sgrava
sgrava requested a review from abussy-pasqal August 12, 2026 10:06
@sgrava sgrava added this to the v1.4 milestone Aug 12, 2026
Comment thread qoolqit/graphs/base_graph.py
Comment thread qoolqit/graphs/base_graph.py
Comment thread tests/test_graphs/test_base_graph.py
sgrava and others added 2 commits August 12, 2026 14:01
Co-authored-by: abussy-pasqal <antoine.bussy@pasqal.com>
@sgrava
sgrava requested a review from abussy-pasqal August 12, 2026 12:09
@sgrava
sgrava merged commit c6f2caf into main Aug 12, 2026
16 checks passed
@sgrava
sgrava deleted the sg/441-scope-graphs-submodules branch August 12, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope graphs submodules

2 participants