Stop forcing edge order in edge_weights setter - #450
Merged
Merged
Conversation
The setter validated input against sorted_edges, so a dict keyed with the "wrong" (but equally valid, for an undirected graph) orientation of an edge was rejected. Delegate straight to nx.set_edge_attributes, which handles either orientation correctly, and drop the list-input branch, which relied on the same unpredictable canonical order. Fixes #447, #448.
sgrava
changed the title
|
abussy-pasqal
left a comment
abussy-pasqal
left a comment
Member
There was a problem hiding this comment.
Can you add in the BaseGraph doc whether the graph is directed or not ?
Collaborator
Author
Fair point, should be more clear now. Please, have a look. |
sgrava
marked this pull request as ready for review
August 14, 2026 12:41
abussy-pasqal
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447, #448.
Completely rewrite
edge_weights.Impl suffered from two issues:
Changes
edge_weightssetter.nx.set_edge_attribute(.., .. ,..)Not fixed here
Leaves
sorted_edgesflying around.