Skip to content

remove is_less_or_equal method - #453

Merged
sgrava merged 1 commit into
mainfrom
sg/remove-less-or-equal-graphs-utils-function
Aug 17, 2026
Merged

sgrava merged 1 commit into
mainfrom
sg/remove-less-or-equal-graphs-utils-function

Conversation

@sgrava

@sgrava sgrava commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Changes

This PR removes the less_or_equal helper from qoolqit/graphs/utils.py and inlines its logic directly into BaseGraph.ud_edges in base_graph.py:

  • ud_edges now takes an explicit tol parameter (default 1e-7) instead of relying on the removed isclose helper, the comparison is now d <= radius + tol.
  • Adds a validation that radius must be non-negative, raising ValueError otherwise.
  • Cleaned up the docstring and error message for missing coordinates.
    less_or_equal and its ATOL_32 constant are deleted from utils.py since ud_edges was their only caller.

Test Plan

no new test added

@sgrava sgrava added this to the v1.4 milestone Aug 17, 2026
@sgrava sgrava linked an issue Aug 17, 2026 that may be closed by this pull request
6 tasks
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-17 12:57 UTC

@sgrava
sgrava requested a review from abussy-pasqal August 17, 2026 12:29
@sgrava
sgrava merged commit 33a0e02 into main Aug 17, 2026
16 checks passed
@sgrava
sgrava deleted the sg/remove-less-or-equal-graphs-utils-function branch August 17, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refine graphs module

2 participants