Skip to content

Support drive composition with different phases - #463

Draft
alessandro-santini wants to merge 2 commits into
mainfrom
as/436-support-drive-composition-with-different-phases
Draft

alessandro-santini wants to merge 2 commits into
mainfrom
as/436-support-drive-composition-with-different-phases

Conversation

@alessandro-santini

@alessandro-santini alessandro-santini commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Changes:

  • drive.py: phase is now stored internally as a ConstantWaveform, composed via the same CompositeWaveform mechanism already used for amplitude/detuning. >> no longer requires equal phases. .phase still returns a float when the whole drive has a uniform phase; raises ValueError if segments differ (use compilation instead of reading .phase directly in that case). draw() now also plots the phase waveform.
  • execution/compilation_functions.py: basic_compilation now emits one PulserPulse per contiguous same-phase run (via new _phase_groups helper) instead of always exactly one pulse. For any drive with a uniform phase this still produces exactly one pulse, so behavior is unchanged.
  • tests/test_drive.py: updated the test that asserted the old NotImplementedError.

@alessandro-santini alessandro-santini linked an issue Sep 4, 2026 that may be closed by this pull request
11 tasks
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1

🚀 View preview at
https://pasqal-io.github.io/qoolqit/pr-preview/pr-463/

Built to branch gh-pages at 2026-09-04 07:55 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support drive composition with different phases

1 participant