Vectorize Simulated Annealing - #276
Open
abussy-pasqal wants to merge 1 commit into
Open
abussy-pasqal wants to merge 1 commit into
abussy-pasqal wants to merge 1 commit into
Conversation
Maintain Qx incrementally instead of recomputing x^T Q x for every candidate flip, deriving each candidate's delta from it via _flip_deltas (moved to the shared qubosolver.utils._costs so tabu_search can reuse it too). Adds a periodic exact recompute of energy/Qx (_REFRESH_EVERY) to bound rounding drift in both the sequential and vectorized runners, and has both recompute costs exactly from the final bitstrings via Solution._update before returning. Also preallocates the vectorized history buffer (visited_bits/ visited_energy) instead of append-then-stack, removing an extra copy and a mixed-dtype torch.stack promotion bug where only the first history entry was cast to Bitstrings's int8 dtype. Parametrizes the test suite over vectorized=True/False, skipping the non-vectorized variant for cases whose n_starts * max_iter would make it too slow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vectorize simulated_annealing's incremental cost tracking
Maintain Qx incrementally instead of recomputing x^T Q x for every candidate flip, deriving each candidate's delta from it via _flip_deltas (moved to the shared qubosolver.utils._costs so tabu_search can reuse it too). Adds a periodic exact recompute of energy/Qx (_REFRESH_EVERY) to bound rounding drift in both the sequential and vectorized runners, and has both recompute costs exactly from the final bitstrings via Solution._update before returning.
Also preallocates the vectorized history buffer (visited_bits/ visited_energy) instead of append-then-stack, removing an extra copy and a mixed-dtype torch.stack promotion bug where only the first history entry was cast to Bitstrings's int8 dtype. Parametrizes the test suite over vectorized=True/False, skipping the non-vectorized variant for cases whose n_starts * max_iter would make it too slow.