Repository navigation
Fix missing separator in odd illustration grids - #18
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With 109 illustrations, the empty bottom-right grid slot leaves no separator below “One edge, two cells”. Complete the last row with a CSS pseudo-element at the two-column breakpoint.
Last row in a two-column grid with an odd count ≥ 3: [last illustration] [empty slot] + 1px top border via ::afterEvidence
::aftercontent:none).After: Injecting the exact CSS rule in the inspection tab produced a 1px top border. With 108 items the pseudo-element was absent; at 390px it was absent and the single-column separator remained 1px. These were computed-style checks, not a deployed change.
bunx biome check app/globals.cssandgit diff --checkpassed.Merge Danger
Door: two-way
Revert the four-line CSS rule to roll back.
Blast Radius: layout
Applies to shared
.sheet-colsgrids at widths ≥ 1280px with an odd count of at least three children.