Repository navigation
Clean up stale references after PR 15 - #16
Merged
Merged
Conversation
…s, --only for inp rows bench.js still called __paint.flushToData(), which went with the idle readback. task.md's status listed PR 14 as in review and the idle readback as current; it now lists PRs 14 and 15 as merged, and its gotchas gain the snapshot frame hold and toBlob's main-thread readback. CLAUDE.md notes that an inp row's --only filter must start with "inp <w>x<h>" (otherwise it's skipped silently). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013pqKTN4jC7Z9ptpugs1h3g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup after #14 and #15. No app code changes.
test/e2e/bench.js: drops the__paint.flushToData()call and its comment. The idle undo readback it waited on was removed with total objects, so the call did nothing.task.md:createImageBitmap(#image)(needskickFrame()), andtoBlob()'s main-thread readback.CLAUDE.md: a bench command line noting that an inp row's--onlyfilter must start withinp <w>x<h>. Otherwise the row is skipped and prints nothing.Checks
inp 4000x3000 fill click) in headless Chromium: inp 32 ms, no errors.Generated by Claude Code