Skip to content

Clean up stale references after PR 15 - #16

Merged
pathanin merged 1 commit into
masterfrom
perf/inp-bench-toggle-nmt3fo
Oct 18, 2026
Merged

pathanin merged 1 commit into
masterfrom
perf/inp-bench-toggle-nmt3fo

Conversation

@pathanin

Copy link
Copy Markdown
Owner

Follow-up cleanup after #14 and #15. No app code changes.

  • test/e2e/bench.js: drops the __paint.flushToData() call and its comment. The idle undo readback it waited on was removed with total objects, so the call did nothing.
  • task.md:
    • The Status section listed PR 14 as "in review" and "undo on the GPU with idle readback" as current. It now lists PRs 14 and 15 as merged, with their headline numbers.
    • It notes that the second-fill row hasn't been checked on the M4 yet.
    • Two new gotchas: the frame held after createImageBitmap(#image) (needs kickFrame()), and toBlob()'s main-thread readback.
  • CLAUDE.md: a bench command line noting that an inp row's --only filter must start with inp <w>x<h>. Otherwise the row is skipped and prints nothing.

Checks

  • Unit 80/80.
  • The edited bench ran one row (inp 4000x3000 fill click) in headless Chromium: inp 32 ms, no errors.

Generated by Claude Code

…s, --only for inp rows

bench.js still called __paint.flushToData(), which went with the idle readback.
task.md's status listed PR 14 as in review and the idle readback as current;
it now lists PRs 14 and 15 as merged, and its gotchas gain the snapshot frame
hold and toBlob's main-thread readback. CLAUDE.md notes that an inp row's
--only filter must start with "inp <w>x<h>" (otherwise it's skipped silently).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013pqKTN4jC7Z9ptpugs1h3g
@pathanin
pathanin marked this pull request as ready for review October 18, 2026 11:04
@pathanin
pathanin merged commit 7bb7d2c into master Oct 18, 2026
3 checks passed
@pathanin
pathanin deleted the perf/inp-bench-toggle-nmt3fo branch October 18, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants