Repository navigation
Safari support - #17
Merged
Merged
Conversation
…allback, text box sizing - test/e2e/browser.js: BROWSER=webkit runs smoke, history, preview, filledge, objects, alpha, libs and shots in Playwright's WebKit; tests allow for its whole-CSS-px mouse input and its premultiplyAlpha:'none' decode bug, and expect native TIFF decoding there - Text box: blur before hiding (Safari keeps focus on hidden elements, which swallowed shortcuts); a toolbar button click no longer commits the text (Safari doesn't focus buttons on click) - Backspace/Delete: preventDefault before the focus check (WebKit can map Backspace to Back) - Pinch: Safari gesture events zoom the image, not the page; ctrl+wheel meanwhile is ignored - Save: a .webp is saved as a PNG copy where there is no WebP encoder (Safari) - Text box sizing fallback where field-sizing is missing (Safari < 26.2) - Resize dialog anchor row laid out without relying on a legend as a flex item - apple-touch-icon for Add to Dock / Home Screen; esbuild target adds safari16.4 Co-Authored-By: Claude <noreply@anthropic.com>
…it again The pointerdown stand-in for the blur's relatedTarget (Safari doesn't focus clicked buttons) took any .chrome element, so such a click left the text open without focus in every browser. Now only enabled controls count. Pinch state also resets on window blur. Smoke checks both clicks. Co-Authored-By: Claude <noreply@anthropic.com>
…, canvas cap check - scene.js: in WebKit the fence's 1 px texImage2D waits for the GPU (~125 ms per big repaint); two slow uploads in a row turn the fence off - assets.js: without requestIdleCallback (Safari) the fallback's deadline never ran down, so a whole bitmap was read back in one task; it now gets 8 ms slices - state.js: canvasFits() refuses sizes past the browser's per-canvas cap (iPadOS 8192²), which otherwise open blank and fail to save - fileio.js: free the JPEG flatten canvas after encoding; keep the download URL 60 s - docs: WebKit dropped its total canvas memory cap in 2023; open items for Safari Co-Authored-By: Claude <noreply@anthropic.com>
- pinch: every gesture event must be cancelled, and ctrl+wheel must zoom again after gestureend - the text box sizing fallback runs with field-sizing forced off (grows with text, fits on reopen) - named checks for the WebKit fixes: focus leaves the committed text box; Backspace on a focused button keeps the page - a downloaded .webp must carry the WEBP signature; which TIFF decoder ran is asserted per engine; the blocked-chunk page accepts dialogs only in WebKit Co-Authored-By: Claude <noreply@anthropic.com>
…check script Safari may block a download started long after the click, and the document would still look saved. After an encode over 1 s the toast keeps a Download again button (a fresh click). Smoke checks both the slow and the quick case. test/e2e/safari.js drives the real Safari over WebDriver; it hasn't connected on this machine yet, so its checks are unverified. Co-Authored-By: Claude <noreply@anthropic.com>
…by hand) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the editor work in Safari. All suites now also run in Safari's engine (Playwright WebKit, `BROWSER=webkit`).
Safari fixes
Tests
Not verified
🤖 Generated with Claude Code