Edit example code in lessons#3
Open
s2t2 wants to merge 4 commits into
Open
Conversation
Author
|
(although I'm at this time running into an error |
Author
|
Most recent push fixes #3 (comment). |
s2t2
changed the title
pathunstrom
requested changes
Sep 22, 2017
Owner
pathunstrom
left a comment
pathunstrom
left a comment
There was a problem hiding this comment.
Added two comments that need changes. When cleaned up, I can accept these changes.
| enemies = self.groups["enemy"] | ||
| groupcollide(player, enemies, True, True) | ||
| groupcollide(enemies, bullets, True, True) | ||
| self.spawner.spawn(time_delta) |
Owner
There was a problem hiding this comment.
This is in lesson six, the scene doesn't have a spawner yet, so this will throw an error.
This line needs to be removed.
| (image.get_width() * 0.5, | ||
| image.get_height() * 0.5)) | ||
| ( int(image.get_width() * 0.5), | ||
| int(image.get_height() * 0.5)) ) |
Owner
There was a problem hiding this comment.
Code samples in this project follow PEP8, extra spaces around parentheses is not to style.
Could you remove them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These revisions get past some issues I was running into when getting to lesson 6 and 7 and 3.