feat: add OMP (Oh My Pi) provider compatibility#9
Merged
Conversation
Support OMP as a host alongside pi: - Convert OMP's array-format system prompts to string via systemPromptToText - Guard against OMP passing the literal env-var name as the API key value - Add ~/.omp/agent/auth.json to default auth path lookup - Fix --list-models output to check both stdout and stderr - Add OMP compatibility smoke test with isolated temp HOME and mock server - Deduplicate usage section in README, add OMP install and usage docs
patlux
requested changes
May 28, 2026
patlux
left a comment
patlux
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR! The OMP compatibility direction looks good, especially the isolated smoke test and the system-prompt conversion. I found a few issues to fix before merge: formatting/check failures, a loose auth regression assertion, unrelated lockfile drift, and one docs/error-message mismatch.
Reviewed with gpt-5.5 xhigh.
- Removed unnecessary blank lines and improved formatting for better readability in index.ts and converters.ts. - Updated package-lock.json to downgrade several dependencies for compatibility, including @protobufjs/eventemitter, @protobufjs/fetch, and others. - Enhanced error message in core.ts to clarify configuration options for the Command Code API key. - Added a test to ensure the correct handling of environment variable values in test-stream.ts.
Owner
|
Thanks @AlexVagrant — all review feedback addressed cleanly. Merging! 🎉 |
Owner
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a new fork repository based on main and fixed the issues from your review.