separated the path to the database from the path to the download output#140
Open
therrealdude wants to merge 2 commits into
Open
separated the path to the database from the path to the download output#140therrealdude wants to merge 2 commits into
therrealdude wants to merge 2 commits into
Conversation
patrickkfkan
left a comment
patrickkfkan
left a comment
Owner
There was a problem hiding this comment.
Thanks. I have made some comments. Also, how would this affect the browse (web server) functionality? I see no changes to the server code.
| export interface DownloaderFileLoggerInit { | ||
| targetURL: string; | ||
| outDir?: string; | ||
| dbDir?: string; |
Owner
There was a problem hiding this comment.
What is the purpose of having dbDir here?
Author
There was a problem hiding this comment.
It seems like nothing. It is removed now.
Comment on lines
+408
to
-467
| console.log('Proceeding...', EOL); | ||
| if (postConfirm) { | ||
| postConfirm(); | ||
| } | ||
| } | ||
| else { | ||
| __logBegin(); | ||
| commonLog(logger, 'debug', null, `Created ${downloaderName} instance with config: `, this.#getDisplayConfig(downloader.getConfig())); | ||
| if (index === 0) { | ||
| __checkProxy(); | ||
| __checkDeno(); | ||
| } | ||
| } | ||
|
|
||
| let hasDownloaderError = false; | ||
| let isAborted = false; | ||
| let endMessage = ''; | ||
| downloader.on('end', ({ aborted, error, message }) => { | ||
| if (aborted) { | ||
| commonLog(logger, 'info', null, `${downloaderName} aborted`); | ||
| isAborted = true; | ||
| } | ||
| else if (!error) { | ||
| commonLog(logger, 'info', null, `${downloaderName} end`); | ||
| } | ||
| else { | ||
| commonLog(logger, 'warn', null, `${downloaderName} end with error`); | ||
| hasDownloaderError = true; | ||
| } | ||
| endMessage = message; | ||
| }); | ||
|
|
||
| try { | ||
| const abortController = new AbortController(); | ||
| const abortHandler = () => { | ||
| abortController.abort(); | ||
| }; | ||
| process.on('SIGINT', abortHandler); | ||
| await downloader.start({ signal: abortController.signal }); | ||
| await logger.end(); | ||
| process.off('SIGINT', abortHandler); | ||
| return { hasError: hasDownloaderError, aborted: isAborted, endMessage }; | ||
| } | ||
| catch (error) { | ||
| commonLog(logger, 'error', null, `Uncaught ${downloaderName} error:`, error); | ||
| return { hasError: true, aborted: isAborted, endMessage: 'Uncaught error' }; | ||
| } | ||
| } | ||
|
|
||
| #confirmProceed(prompt?: PromptSync.Prompt): boolean { | ||
| if (!prompt) { | ||
| prompt = PromptSync({ sigint: true }); | ||
| } | ||
| const confirmProceed = prompt('Proceed (Y/n)? '); | ||
| if (!confirmProceed.trim() || confirmProceed.trim().toLowerCase() === 'y') { | ||
| return true; | ||
| try { | ||
| if (!prompt) { | ||
| prompt = PromptSync({ sigint: true }); | ||
| console.log(); | ||
| } | ||
| const confirmProceed = prompt('Proceed (Y/n)? '); | ||
| if (!confirmProceed.trim() || confirmProceed.trim().toLowerCase() === 'y') { | ||
| console.log('Proceeding...', EOL); | ||
| return true; | ||
| } | ||
| else if (confirmProceed.trim().toLowerCase() === 'n') { | ||
| return false; | ||
| } | ||
|
|
||
| return this.#confirmProceed(prompt); | ||
| } | ||
| else if (confirmProceed.trim().toLowerCase() === 'n') { | ||
| catch (error) { | ||
| console.error('Error obtaining user input: ', error instanceof Error ? error.message : error); | ||
| return false; | ||
| } | ||
|
|
||
| return this.#confirmProceed(prompt); |
Owner
There was a problem hiding this comment.
These changes do not appear to be related to the dbDir feature. If they are unrelated, please move them into a separate PR.
Author
There was a problem hiding this comment.
This should be removed with my latest update
…base at the server level
Author
I just added some code to give the server the same functionality so the user can define the path for the database. Thanks for the feedback. Let me know if you think any more changes would be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had a use case where I needed the database to be in a separate folder from the downloaded content. In my use case, I was trying to backup the data to a Samba share which was not playing well with SQLite. To fix this, I created a new command line argument, db-dir, to specify where the database should be saved. I created a pull request because I believe that this could be a common use case for others who want to backup content to a Samba share, NAS, ZFS share or whatever else there is.