fix: use /c/ prefix in campaign page URL for userId-style vanities#144
Open
dantr4n wants to merge 1 commit into
Open
fix: use /c/ prefix in campaign page URL for userId-style vanities#144dantr4n wants to merge 1 commit into
dantr4n wants to merge 1 commit into
Conversation
For creators without a custom vanity name, Patreon serves their page at
/c/u{userId}. analyzeURL() extracts u{userId} as the vanity from such
URLs, but constructCampaignPageURL() rebuilt the page URL without the
/c/ prefix, landing on the user profile page instead of the creator
page. Initial data parsing then failed with "Initial data not found -
no regex matches".
Fixes patrickkfkan#143
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143
Problem
Downloading posts from a creator without a custom vanity name fails:
analyzeURL()extractsu58344051as the vanity from the/c/-prefixed URL, butconstructCampaignPageURL()rebuilds the page URL without the/c/prefix. Foru{userId}-style placeholder vanities, the barepatreon.com/u{userId}path is the user profile page rather than the creator page, soPageParser.parseInitialData()finds none of its expected patterns.Fix
In
constructCampaignPageURL(), keep the/c/prefix when the vanity matches theu{digits}pattern Patreon uses for creators who never set a custom vanity.Verification
Ran the failing command against the patched build:
Campaign ID resolves and posts fetch and download normally. Creators with regular custom vanities are unaffected (
/^u\d+$/does not match them).🤖 Generated with Claude Code