fix(ChatbotConversationHistoryNav): Make title icon and heading customizable - #616
Merged
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-616.surge.sh A11y report: https://chatbot-pr-chatbot-616-a11y.surge.sh |
kaylachumley
approved these changes
Jul 21, 2025
rebeccaalpert
force-pushed
the
optional-icon
branch
2 times, most recently
from
July 28, 2025 17:55
6d79f3f to
0c9f9df
Compare
rebeccaalpert
changed the title
rebeccaalpert
marked this pull request as ready for review
July 28, 2025 17:56
rebeccaalpert
force-pushed
the
optional-icon
branch
from
August 4, 2025 17:40
0c9f9df to
5f20a76
Compare
Member
Author
|
Putting PR preview here since this was pre-token shift: http://trite-wax.surge.sh/ |
| /** Icon displayed in title */ | ||
| icon?: React.ReactNode; | ||
| /** Heading header level */ | ||
| headingHeaderLevel?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'; |
Collaborator
There was a problem hiding this comment.
Just to relate this and the title:
Suggested change
| headingHeaderLevel?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'; | |
| titleHeadingLevel?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'; |
Unless we'd want to just allow spreading TitleProps here as well, since we're importing that for the Title's used in the list headers. In that case may want to rename things a bit, maybe titleProps becomes listTitleProps or something, and this becomes navTitleProps?
Member
Author
There was a problem hiding this comment.
Good call-out; thank you!
rebeccaalpert
force-pushed
the
optional-icon
branch
2 times, most recently
from
August 4, 2025 20:36
f232a01 to
42614e1
Compare
…mizable Also change spacing between icon and title to 0.5rem.
rebeccaalpert
force-pushed
the
optional-icon
branch
from
August 4, 2025 20:37
42614e1 to
0e76b30
Compare
thatblindgeye
approved these changes
Aug 5, 2025
|
🎉 This PR is included in version 6.4.0-prerelease.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
added a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
…mizable (patternfly#616) Also change spacing between icon and title to 0.5rem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also change spacing between icon and title to 0.5rem per design spec. To merge after Mash's PR merges.
https://chatbot-pr-chatbot-616.surge.sh/patternfly-ai/chatbot/ui#drawer-with-search-and-new-chat-button