Skip to content

feat(SourcesCard): Allow for subtitles and custom footers - #661

Merged
rebeccaalpert merged 2 commits into
patternfly:mainfrom
rebeccaalpert:sources-card-footer
Sep 4, 2025
Merged

rebeccaalpert merged 2 commits into
patternfly:mainfrom
rebeccaalpert:sources-card-footer

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Aug 21, 2025

Copy link
Copy Markdown
Member

Added demo with tests. Also passing some additional props down while I am in there.

I am completely dropping the paginated footer when a custom footer is passed in - this means that you can't have more than one source for now, or that you'd have to implement your own pagination system as part of your custom footer. I have a separate ticket to make sources importable outside of Message so people can do funky stuff with layouts if need be.

Example: https://chatbot-pr-chatbot-661.surge.sh/patternfly-ai/chatbot/messages#messages-with-sources

@patternfly-build

patternfly-build commented Aug 21, 2025

Copy link
Copy Markdown

@rebeccaalpert
rebeccaalpert force-pushed the sources-card-footer branch 4 times, most recently from 64bc3f9 to 130a70d Compare August 21, 2025 17:41
@rebeccaalpert
rebeccaalpert marked this pull request as ready for review August 21, 2025 17:42
Added demo with tests. Also passing some additional props down while I am in there.

@kaylachumley kaylachumley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@rebeccaalpert
rebeccaalpert merged commit 8a83a33 into patternfly:main Sep 4, 2025
7 checks passed
@github-actions

github-actions Bot commented Sep 4, 2025

Copy link
Copy Markdown

🎉 This PR is included in version 6.4.0-prerelease.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

rebeccaalpert added a commit to rebeccaalpert/virtual-assistant that referenced this pull request Oct 24, 2025
…#661)

Added demo with tests. Also passing some additional props down while I am in there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add potential for subheaders and extra body content to Sources card

4 participants