feat(Chatbot): Move scrollbar for embedded - #868
Merged
Merged
Conversation
|
Preview: https://chatbot-pr-chatbot-868.surge.sh A11y report: https://chatbot-pr-chatbot-868-a11y.surge.sh |
| tabIndex={0} | ||
| aria-label={ariaLabel} | ||
| className={`pf-chatbot__messagebox ${position === 'bottom' ? 'pf-chatbot__messagebox--bottom' : ''} ${className ?? ''}`} | ||
| className={`pf-chatbot__messagebox ${position === 'bottom' ? 'pf-chatbot__messagebox--bottom' : ''} ${hasOuterScrollbar ? 'pf-chatbot__messagebox--outer-scroll' : ''} ${className ?? ''}`} |
Collaborator
There was a problem hiding this comment.
Can we import the css helper from Patternfly to create the className string?
Move scrollbar to far right for embedded layouts only. Fixes patternfly#886
thatblindgeye
approved these changes
Aug 10, 2026
|
🎉 This PR is included in version 6.8.0-prerelease.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Open
7 tasks
aminabai
added a commit
to aminabai/odh-dashboard
that referenced
this pull request
Aug 24, 2026
Bumping @patternfly/chatbot to 6.8.0-prerelease.8 pulled PatternFly 6.6 into a 6.5 Playground and Cypress could not find data-testid="chatbot". Keep 6.5 and use the same layout CSS as patternfly/chatbot#868 locally. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move scrollbar to far right for embedded layouts only if appropriate prop is used. See https://github.com/opendatahub-io/odh-dashboard/pull/8199/changes.
Fixes #886