Removed react element from config as that makes template unserializable - #14
Merged
Merged
Conversation
Hyperkid123
approved these changes
Nov 26, 2025
| initialTemplate={template} | ||
| onTemplateChange={(newTemplate) => { | ||
| setTemplate(newTemplate); | ||
| console.log('newTemplate', JSON.stringify(newTemplate, null, 2)); |
Collaborator
There was a problem hiding this comment.
Extra debug statement
Collaborator
|
Thank you, jsut one small nit. Unless the log was deliberate for the example. |
Contributor
Author
|
@Hyperkid123 right it was as meant as an example, removed it now |
Collaborator
|
@edewit if you could rebase the branch, that would be great. It should fix the CI issues. |
fixes: patternfly#13 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
|
🎉 This PR is included in version 1.0.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opted to make as little changes as needed to fix this issue only removing the icon from the config, but another option would be to completely remove the config, as it's already
widgetMappingfixes: #13
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com