Feature/boot relaxed binding#59
Conversation
use "0.0.0-SNAPSHOT" instead of "unspecified"
Surprisingly, it's faster this way. But that's not the point; tests that use system properties need special care, and running tests in sequence is just safer.
- Add spring configuration properties annotation processing to auto-generate config option documentation - Improve testing for spring, boot3, boot4
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (dotenvConfig.exportToSystemProperties()) { | ||
| log.trace("Dotenv environment available as system properties"); | ||
| } else { | ||
| var sources = environment.getPropertySources(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Load .env even when exporting to system properties
When springdotenv.exportToSystemProperties=true, this early return skips creating the DotenvPropertyLoader, so the .env file is never loaded and nothing is actually exported into System.getProperties(). In the previous behavior, the loader was constructed before the export check, which triggered the dotenv library to populate system properties. As a result, anyone enabling export will now see missing system properties and no .env values at all in both Spring and Boot paths.
Useful? React with 👍 / 👎.
See #16