Skip to content

Feature/boot relaxed binding#59

Merged
paulschwarz merged 7 commits into
mainfrom
feature/boot-relaxed-binding
Jan 2, 2026
Merged

Feature/boot relaxed binding#59
paulschwarz merged 7 commits into
mainfrom
feature/boot-relaxed-binding

Conversation

@paulschwarz
Copy link
Copy Markdown
Owner

See #16

use "0.0.0-SNAPSHOT" instead of "unspecified"
Surprisingly, it's faster this way. But that's not the point; tests that use system properties need special care, and running tests in sequence is just safer.
- Add spring configuration properties annotation processing to auto-generate config option documentation
- Improve testing for spring, boot3, boot4
@paulschwarz paulschwarz merged commit ad8cedb into main Jan 2, 2026
2 checks passed
@paulschwarz paulschwarz deleted the feature/boot-relaxed-binding branch January 2, 2026 05:36
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 102 to +105
if (dotenvConfig.exportToSystemProperties()) {
log.trace("Dotenv environment available as system properties");
} else {
var sources = environment.getPropertySources();
return;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Load .env even when exporting to system properties

When springdotenv.exportToSystemProperties=true, this early return skips creating the DotenvPropertyLoader, so the .env file is never loaded and nothing is actually exported into System.getProperties(). In the previous behavior, the loader was constructed before the export check, which triggered the dotenv library to populate system properties. As a result, anyone enabling export will now see missing system properties and no .env values at all in both Spring and Boot paths.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant