Repository navigation
Conversation
…pdate the checkProofOfWork comment Review follow-up to paulscode#2. The new test sends ProcessBlock a v2 orphan committing to the block below the activation (refused, ErrBadHeaderV2) and the same orphan committing to the activation height (kept as an orphan); it fails if the call in process.go is removed. The comment in checkProofOfWork now names both places the height of a v2 header is checked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the two nits on #2.
TestProcessBlockHeaderV2Sanitysends ProcessBlock a v2 orphan that commits to the block below the activation, which must be refused with ErrBadHeaderV2, and the same orphan committing to the activation height, which must be kept as an orphan. With the call inprocess.goremoved, the test fails (got <nil>, want ErrBadHeaderV2).checkProofOfWorknow names both checks:CheckHeaderV2Sanitybefore the real height is known, andcheckHeaderV2Contextagainst the real height.blockchain, chaincfg, txscript and mempool tests pass.