Repository navigation
Conversation
…tead of sleeping Follow-up to lightningnetwork#10. The test slept 100 ms for the link to handle the tx_abort. The peer's messages are handled in order on the link's goroutine, so it now sends an stfu after the abort and waits for the answer: the abort has been handled by then. Still fails with the old link code, 20 runs in a row pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10, from your review there.
The test slept 100 ms for the link to handle the tx_abort. The peer's messages are handled in order on the link's goroutine, so it now sends an stfu after the abort and waits for the reply: by then the abort has been handled.
Still fails with the old link code (checked by reverting #10's link changes), and passes 20 runs in a row with
-tags dev.