Repository navigation
Conversation
Keep lnd compatible with the previous stable Go release by updating the language version in every tracked go.mod file to Go 1.26.10. Move build and release tooling to Go 1.27.3, including CI, Docker images, the Makefile, protobuf generation, the linter configuration, and mobile build documentation. Update the installation documentation and official Linux archive checksums for Go 1.26.10 as well. (cherry picked from commit d67c9ed) (cherry picked from commit 6389391)
Owner
|
Thanks, merged by hand as b6c4f6a on blake2b-next (the merge button needs a workflow permission my token doesn't have, since the PR touches .github/workflows). The Fork checks failure was a test flake, not the bump: TestLinkHeldBounded/too_many floods 1001 held messages, the mailbox also caps at 1000, and on a busy runner its cap disconnects the peer first through a path the test's mock ignored. That's fixed in ace886e. The checksums match go.dev, and the full fork.yml job passes under 1.27.3. This ships as 0.21.4-beta-blake2b.21.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream lnd v0.21.5-beta.rc1 is built with Go 1.27.3 because of CVE-2026-111943 (golang/go#82345): Go's
crypto/x509now rejects certificate chains through a set of compromised intermediates. Binaries built with 1.27.2 still trust them, which matters for every outbound HTTPS call the node makes:fee.urland the bridge's price sources.This cherry-picks upstream's toolchain bump (6389391) onto blake2b-next:
make check-go-versionlooks (Makefile, Dockerfiles, workflows incl. fork.yml, .golangci.yml, lnrpc, tools, mobile docs);scripts/native-ubuntu.sh: Go 1.27.3 with the official linux-amd64/arm64 SHA-256 from go.dev.Conflicts were only the version strings (the fork was on 1.27.2, upstream on 1.27.1); the fork's own content in those files is kept.
./cmd/lndbuilds with Go 1.27.3 (go version lnd→ go1.27.3).Not included: the rest of v0.21.5 (revocation validation order, TLV decoder allocations, fee.url ceiling, commit fee floor). A trial merge conflicts in
lnwallet/channel.go,htlcswitch/link.go,peer/brontide.goandrpcserver.go, so it's better merged by you when v0.21.5 is final. Happy to help with it.