Repository navigation
fix: shared link controls answer while the link restores - #128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a shared link, the about panel, the locate control and Back did
nothing until the two reverse geocodes that resolve the link's country
came back: seconds on a slow geocoder, the whole timeout if it failed.
Their listeners were registered after
await restoreFromUrl().initLocateMe,initAboutDrawerandinitNavigationbefore the restore.
button already was: it sat over the map controls during the restore.
state.restoringkeeps a popstate during the restore (Forward ontothe about entry) from restoring the link a second time.
shared-link-restore.spec.jsholds the reverse geocodes: the aboutpanel opens and Back closes it, the locate control answers, and
Forward does not restore twice. All three fail on main.