Skip image paste when clipboard also has text#64
Merged
Conversation
When pasting from Word (and similar rich-text editors), the clipboard contains both the text/html content and a PNG screenshot of the selection. The previous handler would let CodeMirror insert the text and then also upload the screenshot, producing duplicate output. If the clipboard carries text/plain or text/html alongside an image file blob, treat the image as a redundant rendering and skip the upload. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pastehandler inEditPage.tsxruns after CodeMirror's own paste handler (bubble phase), soe.preventDefault()could not stop CodeMirror from inserting the text first; the handler then uploaded the screenshot on top.text/plainortext/htmlalongside an image file blob, treat the image as a redundant rendering and skip the upload. Pure-image pastes (Finder, screenshot tools, "Copy Image") still upload as before.Trade-off
urn:schemas-microsoft-com:office,Mso…classes) instead of any text presence.Test plan
pasted-*.pngupload.<img src>in HTML, not as file blobs).🤖 Generated with Claude Code